I used to have a Creative Zen player that I could fit nearly my whole collection on. That thing was great. But yeah it had a hard disc drive and while it lasted several years because I was careful with it I used it so much that it was inevitable that it would get dropped one too many times and that killed it eventually. I now use Sansa Clips with SD cards and while I like those a lot they aren't as great as my old player was.
If they were to relaunch old Mp3 players like these they'd have to market them specifically to music nerds because general audiences just use their phones for mobile music now. And we already had a company try that with Pono and it was a huge failure.