- 100% agree Archived Message
Posted by illinibone
on February 21, 2025, 13:12:03, in reply to "Sounds like you need code review more then ever if everyone thinks it’s unreadable."
|
We write some pretty critical, high performance data plane code (and of course it's async which is its own separate mindf*). We've got a few established patterns, but the only thing keeping those from going to crap is code reviews from more experienced folks. I've seen some horrific attempts both from more junior developers, and from new hire senior developers. Code reviews also have the benefit of more people understanding what the code does.  Previous MessageEven specialized code can be written to be readable. Previous MessageBasically one person covers the subject matter and there's (emergency) backups for vacations. You'd be able to see the structure of the code being bad, but not always able to see problems in the actual content. There's 12 on the team and 3 of us are senior level, we've talked about code review but it's just never materialized. Previous MessageIf so, use that mechanism (and if not, time to start!). It doesn't have to be a formal tool like jenkis or reviewboard or whatever, but even an over the shoulder or email review can be helpful. Just a quick un-emotional note may be helpful. "Hey, I was looking through X and found lines ZZ-ZZ a bit confusing. You might consider using Z as a better way to approach the problem. Also, I think there's a bug on line ZZ, it looks like XXX is the thing you're looking for." Previous MessageCovering for a coworker while he's gone for 3 weeks. Coworker is newer to the general field, and is big into ChatGPT and the other stupid AI nonsense. I just had to fix some completely wrong code he wrote and has been using for a while. I'm about 75% that he tried to just have some AI model write the query and then he didn't really double check it. ALso possible that he didn't know what he's doing, but this guy has been around long enough to know better. Still, the mistakes look AI-ish Would you confront them on return, or just fix it and move on? |
- IlliniSax05 February 21, 2025, 13:51:32